NeurodataWithoutBorders / matnwb

A Matlab interface for reading and writing NWB files
BSD 2-Clause "Simplified" License
48 stars 32 forks source link

Fix: bug in nwbToTable (Issue #597 ) #598

Closed ehennestad closed 1 month ago

ehennestad commented 2 months ago

Fix #597

Motivation

fix bug

How to test the behavior?

See issue

Checklist

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.59%. Comparing base (c51099f) to head (79e76a1).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #598 +/- ## ========================================== - Coverage 90.60% 90.59% -0.01% ========================================== Files 106 106 Lines 4671 4670 -1 ========================================== - Hits 4232 4231 -1 Misses 439 439 ``` | [Flag](https://app.codecov.io/gh/NeurodataWithoutBorders/matnwb/pull/598/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NeurodataWithoutBorders) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/NeurodataWithoutBorders/matnwb/pull/598/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NeurodataWithoutBorders) | `90.59% <100.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NeurodataWithoutBorders#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bendichter commented 2 months ago

Can you please add a test that fails before and passes now?