NeurodataWithoutBorders / matnwb

A Matlab interface for reading and writing NWB files
BSD 2-Clause "Simplified" License
48 stars 32 forks source link

Change: Only embed specs/namespaces for types that are included in NWB file on export #615

Open ehennestad opened 3 weeks ago

ehennestad commented 3 weeks ago

Fix #607

Motivation

Ensure that only relevant namespaces/specifications are embedded in an NWB file. This issue suggests that such extra namespaces can cause errors when validating with NWBInspector.

How to test the behavior?

Export NWB file with types from a subset of available extension and check the file's `specification` group

Questions / todo

Checklist

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.00%. Comparing base (95b5e5e) to head (a458d62). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #615 +/- ## ========================================== + Coverage 90.90% 91.00% +0.09% ========================================== Files 107 107 Lines 4751 4768 +17 ========================================== + Hits 4319 4339 +20 + Misses 432 429 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.