NeurodataWithoutBorders / matnwb

A Matlab interface for reading and writing NWB files
BSD 2-Clause "Simplified" License
48 stars 32 forks source link

Add MotionCorrection, CorrectedImageStack and DeltaFOverF to ophys tutorial #629

Closed ehennestad closed 1 day ago

ehennestad commented 6 days ago

Motivation

Add NWB types to tutorial to reach 100% tutorial coverage

How to test the behavior?

Run ophys live script

Checklist

bendichter commented 6 days ago

The test fails when trying to read the output nwb with pynwb, with the following error message:

 "Could not construct CorrectedImageStack object due to: CorrectedImageStack.__init__: missing argument 'original'"

The original property of the CorrectedImageStack object is set, and also present when I read the file back with matnwb.

@rly do you know why this might be happening? @ehennestad , could you provide a sample file?

ehennestad commented 6 days ago

The object in question should be added as a link. Issue #559 already discusses how the matnwb api is not enforcing links for types that should be links

codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.16%. Comparing base (e070e20) to head (60f37a6).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #629 +/- ## ======================================= Coverage 95.16% 95.16% ======================================= Files 113 113 Lines 4734 4734 ======================================= Hits 4505 4505 Misses 229 229 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: