NeurodataWithoutBorders / nwb-guide

NWB GUIDE is a desktop app that provides a no-code user interface for converting neurophysiology data to NWB.
https://nwb-guide.readthedocs.io/
MIT License
21 stars 3 forks source link

Kilosort import syntax errors don't specify filename #890

Open dhmjhu opened 2 weeks ago

dhmjhu commented 2 weeks ago

Describe the issue

When trying to import Kilosort data, syntax errors in params.py refer to <string> instead of a real filename.

Trying to import a Kilosort directory with an invalid params.py leads to a message like:

Request Failed invalid syntax (, line 3)

Screenshot of error message

The above message was not properly escaped (see #889). It should say:

Request Failed invalid syntax (\<string>, line 3)

It would be helpful if the filename containing the syntax error could be displayed instead of <string>. This may affect other formats, but I've only tried it with Kilosort.

Steps to Reproduce

  1. Add a syntax error to an existing Kilosort params.py or use guide-error-example.zip
  2. Create a new conversion pipeline with a "KiloSort Sorting" source format
  3. Select the directory containing the invalid params.py and click "Next"

Operating System

Windows 11 23H2 Enterprise

GUIDE Version

1.0.2

Code of Conduct

Yes

Did you confirm this issue was not already reported?

Yes

CodyCBakerPhD commented 2 weeks ago

It would be helpful if the filename containing the syntax error could be displayed instead of . This may affect other formats, but I've only tried it with Kilosort.

This would be helpful, but is not something we would implement on the GUIDE but rather NeuroConv; we have some refactors to source schemas there over the next few months that should make these types of errors a bit more explicit