search

NeurodataWithoutBorders / nwb-overview

Introduction to NWB software
https://nwb-overview.readthedocs.io/
7 stars 8 forks source link

add nwbview #149

Closed anilbey closed 9 months ago

anilbey commented 9 months ago

Hi folks :)

A follow-up PR after the SfN conference. Addressing https://github.com/NeurodataWithoutBorders/nwb-overview/issues/123.

I built it locally it renders fine. The html newlines are added for it to look nice. Here is the screenshot below.

Screenshot from 2024-02-08 13-35-19

anilbey commented 9 months ago

@oruebel @rly could you review the PR? :)

I think the CI at the moment is failing for another reason.

oruebel commented 9 months ago

I think the CI at the moment is failing for another reason.

CI is running now. I just had to approve it. I'm taking a look at the PR now.

oruebel commented 9 months ago

Looks like some links are broken. I'll make a separate PR to fix links and then this should be good to merge.

oruebel commented 9 months ago

@stephprince could you take a look at the broken link issue? I tried to add the configuration for the linkchecker to ignore the link but for some reason it doesn't seem to work.

oruebel commented 9 months ago

Looks like the failing linkcheck is now a seperate issue with a timeout form biorxiv. It looks like https://www.biorxiv.org/ may be unavailable for some reason right now. I think we can probably just rerun the linkchecker again later and then merge.

anilbey commented 9 months ago

Great, thanks for your effort

oruebel commented 9 months ago

Thanks @anilbey ! All tests passed now and I have merged the PR.