search

NeurodataWithoutBorders / nwb-schema

Data format specification schema for the NWB neurophysiology data format
http://nwb-schema.readthedocs.io
Other
53 stars 16 forks source link

icephys.yaml: Some entries miss unit attribute #410

Open t-b opened 4 years ago

t-b commented 4 years ago

The CurrentClampSeries properties https://github.com/NeurodataWithoutBorders/nwb-schema/blob/571bfb03476c940e27b879aad64a1e5813a9e9e5/core/nwb.icephys.yaml#L53-L80 don't have a units attributes whereas

https://github.com/NeurodataWithoutBorders/nwb-schema/blob/571bfb03476c940e27b879aad64a1e5813a9e9e5/core/nwb.icephys.yaml#L115-L130 do have unit attributes. This is inconsistent.

bendichter commented 3 years ago

Thanks, @t-b. It looks like this is being handled in https://github.com/NeurodataWithoutBorders/nwb-schema/pull/446