NeurodataWithoutBorders / nwb_hackathons

Repository for collecting materials from nwb hackathons
https://neurodatawithoutborders.github.io/nwb_hackathons
22 stars 85 forks source link

Note: Preview docs contain link to deployed site not preview site #316

Closed rly closed 2 months ago

rly commented 2 months ago

A note for future reference. The preview docs site in PRs such as https://neurodatawithoutborders.github.io/nwb_hackathons/pr-preview/pr-315/ contain internal links that use the deployed site rather than the preview site. For example, the preview contains links to https://neurodatawithoutborders.github.io/nwb_hackathons/HCK21_2024_Janelia_NDRH/ rather than https://neurodatawithoutborders.github.io/nwb_hackathons/pr-preview/pr-315/HCK21_2024_Janelia_NDRH/

See also https://github.com/rossjrw/pr-preview-action/issues/14

I'm not sure how to address that in the Jekyll config so that the preview has one base URL determined programmatically ("pr-preview/pr-315") and the deployed site has another ("/"). They both publish on the gh-pages branch.

I'm not sure how to resolve this quickly, and it's not a big deal. Just something to remember when browsing the preview docs site.