NeurodataWithoutBorders / nwbinspector

Tool to help inspect NWB files for compliance with NWB Best Practices
https://nwbinspector.readthedocs.io/
Other
17 stars 10 forks source link

[Bug]: Should 'is_ascending_series' skip NaNs? #343

Open CodyCBakerPhD opened 1 year ago

CodyCBakerPhD commented 1 year ago

What happened?

This was discovered during a particular check run, but the question is more general

I have a time vector (in this case a table column) that has a small number of NaN's in it but most of the time has well-behaved strictly ascending floats

Should our util function for determining if a time vector is ascending filter out NaN values?

Steps to Reproduce

No response

Traceback

No response

Operating System

Windows

Python Executable

Conda

Python Version

3.7

Usage

Command Line Interface

Were you streaming with ROS3?

No

Package Versions

No response

Code of Conduct

bendichter commented 1 year ago

Seems reasonable

bendichter commented 1 year ago

This makes more sense for time columns than it does for time stamps in a TimeSeries

CodyCBakerPhD commented 1 year ago

This makes more sense for time columns than it does for time stamps in a TimeSeries

True, maybe it can be a flag in the util function, and each check can decide whether it is appropriate based on the type

bendichter commented 1 year ago

That sounds like a good approach