NeurodataWithoutBorders / nwbinspector

Tool to help inspect NWB files for compliance with NWB Best Practices
https://nwbinspector.readthedocs.io/
Other
17 stars 10 forks source link

Final deprecation of `insect_nwb` #505

Closed CodyCBakerPhD closed 2 months ago

CodyCBakerPhD commented 2 months ago

Really making use of the 'or after' clause on this one

CodyCBakerPhD commented 2 months ago

@stephprince Sharp eye!

When you add documentation tests, it might be nice to make them 'nitpicky' (throw error on warning, such as deprecations) to automatically catch such things

Removed those items

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.91%. Comparing base (27e4d25) to head (328679e). Report is 1 commits behind head on dev.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/NeurodataWithoutBorders/nwbinspector/pull/505/graphs/tree.svg?width=650&height=150&src=pr&token=772QROR5F0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NeurodataWithoutBorders)](https://app.codecov.io/gh/NeurodataWithoutBorders/nwbinspector/pull/505?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NeurodataWithoutBorders) ```diff @@ Coverage Diff @@ ## dev #505 +/- ## ========================================== + Coverage 79.33% 84.91% +5.57% ========================================== Files 48 48 Lines 1423 1419 -4 ========================================== + Hits 1129 1205 +76 + Misses 294 214 -80 ``` | [Files with missing lines](https://app.codecov.io/gh/NeurodataWithoutBorders/nwbinspector/pull/505?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NeurodataWithoutBorders) | Coverage Δ | | |---|---|---| | [src/nwbinspector/\_nwb\_inspection.py](https://app.codecov.io/gh/NeurodataWithoutBorders/nwbinspector/pull/505?src=pr&el=tree&filepath=src%2Fnwbinspector%2F_nwb_inspection.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NeurodataWithoutBorders#diff-c3JjL253Ymluc3BlY3Rvci9fbndiX2luc3BlY3Rpb24ucHk=) | `85.49% <ø> (+6.23%)` | :arrow_up: | | [src/nwbinspector/nwbinspector/\_\_init\_\_.py](https://app.codecov.io/gh/NeurodataWithoutBorders/nwbinspector/pull/505?src=pr&el=tree&filepath=src%2Fnwbinspector%2Fnwbinspector%2F__init__.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NeurodataWithoutBorders#diff-c3JjL253Ymluc3BlY3Rvci9ud2JpbnNwZWN0b3IvX19pbml0X18ucHk=) | `0.00% <ø> (ø)` | | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/NeurodataWithoutBorders/nwbinspector/pull/505/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NeurodataWithoutBorders)