search

NeurodataWithoutBorders / nwbinspector

Tool to help inspect NWB files for compliance with NWB Best Practices
https://nwbinspector.readthedocs.io/
Other
17 stars 10 forks source link

Fix incorrect error message for opto stimulus site #524

Closed rly closed 1 month ago

rly commented 1 month ago

Motivation

The error message is incorrect.

rly commented 1 month ago

Thanks for updating the test! You'll have to re-approve.

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.83%. Comparing base (c453b68) to head (77065e3). Report is 2 commits behind head on dev.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/NeurodataWithoutBorders/nwbinspector/pull/524/graphs/tree.svg?width=650&height=150&src=pr&token=772QROR5F0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NeurodataWithoutBorders)](https://app.codecov.io/gh/NeurodataWithoutBorders/nwbinspector/pull/524?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NeurodataWithoutBorders) ```diff @@ Coverage Diff @@ ## dev #524 +/- ## ========================================== + Coverage 82.77% 86.83% +4.05% ========================================== Files 47 47 Lines 1504 1504 ========================================== + Hits 1245 1306 +61 + Misses 259 198 -61 ``` | [Files with missing lines](https://app.codecov.io/gh/NeurodataWithoutBorders/nwbinspector/pull/524?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NeurodataWithoutBorders) | Coverage Δ | | |---|---|---| | [src/nwbinspector/checks/\_ogen.py](https://app.codecov.io/gh/NeurodataWithoutBorders/nwbinspector/pull/524?src=pr&el=tree&filepath=src%2Fnwbinspector%2Fchecks%2F_ogen.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NeurodataWithoutBorders#diff-c3JjL253Ymluc3BlY3Rvci9jaGVja3MvX29nZW4ucHk=) | `100.00% <100.00%> (ø)` | | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/NeurodataWithoutBorders/nwbinspector/pull/524/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NeurodataWithoutBorders)