NeurodataWithoutBorders / nwbinspector

Tool to help inspect NWB files for compliance with NWB Best Practices
https://nwbinspector.readthedocs.io/
Other
17 stars 10 forks source link

Remove numpy and h5py restrictions #536

Open rly opened 1 day ago

rly commented 1 day ago

Motivation

numpy was pinned to <2.0 due to incompatibilities in pynwb and hdmf-zarr and maybe other tools. Those should be resolved now.

h5py was pinned to <3.12.0 due to an issue with windows that has been fixed and released.

codecov-commenter commented 2 hours ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.72%. Comparing base (dd39d0e) to head (527871f).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/NeurodataWithoutBorders/nwbinspector/pull/536/graphs/tree.svg?width=650&height=150&src=pr&token=772QROR5F0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NeurodataWithoutBorders)](https://app.codecov.io/gh/NeurodataWithoutBorders/nwbinspector/pull/536?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NeurodataWithoutBorders) ```diff @@ Coverage Diff @@ ## dev #536 +/- ## ========================================== + Coverage 82.68% 86.72% +4.04% ========================================== Files 47 47 Lines 1507 1507 ========================================== + Hits 1246 1307 +61 + Misses 261 200 -61 ``` | [Files with missing lines](https://app.codecov.io/gh/NeurodataWithoutBorders/nwbinspector/pull/536?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NeurodataWithoutBorders) | Coverage Δ | | |---|---|---| | [src/nwbinspector/checks/\_tables.py](https://app.codecov.io/gh/NeurodataWithoutBorders/nwbinspector/pull/536?src=pr&el=tree&filepath=src%2Fnwbinspector%2Fchecks%2F_tables.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NeurodataWithoutBorders#diff-c3JjL253Ymluc3BlY3Rvci9jaGVja3MvX3RhYmxlcy5weQ==) | `97.45% <100.00%> (ø)` | | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/NeurodataWithoutBorders/nwbinspector/pull/536/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NeurodataWithoutBorders)

🚨 Try these New Features:

rly commented 2 hours ago

The Windows failure is due to a change in Numpy 2.0:

The default integer type on Windows is now int64 rather than int32, matching the behavior on other platforms

The tests need to be updated. I'll do this next week.