Open alejoe91 opened 1 year ago
Attention: Patch coverage is 80.00000%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 66.24%. Comparing base (
fdc0309
) to head (03a598a
).
Files | Patch % | Lines |
---|---|---|
nwbwidgets/timeseries.py | 80.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@alejoe91 it looks like Zarr does actually support fancy indexing, though the syntax is different from numpy
https://zarr.readthedocs.io/en/stable/tutorial.html#advanced-indexing
@bendichter should we use the Zarr fancy indexing functions when the dataset is a Zarr object then?
Yes that would be an immediate fix. But this issue is going to come up for anything downstream of pynwb so maybe it makes sense to fix on the pynwb level. Maybe we could wrap all arrays in xarray?
@alejoe91 can you also please add checks that this data indexing utility does indeed solve the problem for Zarr dataset objects?
Turns out fancy indexing is not supported for
zarr.Dataset
objects and this was causing an issue in displaying timeseries correctly.This small PR fixes it by changing the behavior of the
timeseries.py
and:Not that for NWBwidgets in all cases we can slice directly, because of the channel slider.