Closed bjhardcastle closed 1 year ago
Merging #288 (d651b53) into master (1913147) will increase coverage by
0.01%
. The diff coverage is25.00%
.
@@ Coverage Diff @@
## master #288 +/- ##
==========================================
+ Coverage 66.26% 66.27% +0.01%
==========================================
Files 70 35 -35
Lines 6883 3443 -3440
==========================================
- Hits 4561 2282 -2279
+ Misses 2322 1161 -1161
Flag | Coverage Δ | |
---|---|---|
unittests | 66.27% <25.00%> (+0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
nwbwidgets/brains.py | 21.21% <0.00%> (ø) |
|
nwbwidgets/misc.py | 71.07% <0.00%> (ø) |
|
...bwidgets/controllers/group_and_sort_controllers.py | 87.56% <100.00%> (ø) |
... and 35 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Apologies, I missed one.
Or rather, the search function on the github.dev/
view of a repository is either not exhaustive, or slow enough that it can look finished when it's not!
I re-checked for all of the types - hopefully that is all of them now.
@bjhardcastle thanks for the contribution!
np.float
: https://numpy.org/doc/stable/release/1.24.0-notes.htmlnp.integer
still okay to check against abc for all numpy intsnp.object
,np.bool
,np.float
,np.complex
,np.str
,np.int
np.float64
innwbwidgets/misc.py
, which is still okay, but updated anyway to include built-in and all numpy floating point types