NeurodataWithoutBorders / nwbwidgets

Explore the hierarchical structure of NWB 2.0 files and visualize data with Jupyter widgets.
https://nwb-widgets.readthedocs.io/en/latest/
Other
48 stars 21 forks source link

fix #264 #295

Closed luiztauffer closed 1 year ago

luiztauffer commented 1 year ago

fix #264

that issue was being caused by <Closed HDF5 dataset>, setting io variable to class (self.io) fixed the error

codecov[bot] commented 1 year ago

Codecov Report

Merging #295 (877309f) into master (b99aa49) will decrease coverage by 0.03%. The diff coverage is 41.66%.

@@            Coverage Diff             @@
##           master     #295      +/-   ##
==========================================
- Coverage   66.28%   66.25%   -0.03%     
==========================================
  Files          35       35              
  Lines        3470     3476       +6     
==========================================
+ Hits         2300     2303       +3     
- Misses       1170     1173       +3     
Flag Coverage Δ
unittests 66.25% <41.66%> (-0.03%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nwbwidgets/timeseries.py 58.66% <ø> (ø)
nwbwidgets/view.py 96.55% <ø> (ø)
nwbwidgets/panel.py 77.01% <22.22%> (-1.10%) :arrow_down:
nwbwidgets/behavior.py 74.22% <100.00%> (+0.26%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

CodyCBakerPhD commented 1 year ago

@luiztauffer This appears to be working as far as I can tell now! Will re-open issue if discovered again

Thanks for pinning this one down

No way to write tests for it obviously, but can you update the changelog, cut a release, update the DANDIHub build version, and request Satra rebuild the Hub? (since you're becoming more in charge of this repo, right?)