NeurodataWithoutBorders / nwbwidgets

Explore the hierarchical structure of NWB 2.0 files and visualize data with Jupyter widgets.
https://nwb-widgets.readthedocs.io/en/latest/
Other
47 stars 22 forks source link

Docker/Panel fixes and improvements #299

Closed luiztauffer closed 1 year ago

luiztauffer commented 1 year ago
codecov[bot] commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@057cfed). Click here to learn what that means. The diff coverage is 57.14%.

@@            Coverage Diff            @@
##             master     #299   +/-   ##
=========================================
  Coverage          ?   66.22%           
=========================================
  Files             ?       35           
  Lines             ?     3467           
  Branches          ?        0           
=========================================
  Hits              ?     2296           
  Misses            ?     1171           
  Partials          ?        0           
Flag Coverage Δ
unittests 66.22% <57.14%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nwbwidgets/panel.py 76.96% <53.84%> (ø)
nwbwidgets/version.py 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

bendichter commented 1 year ago

lgtm! @CodyCBakerPhD could you take a look as well since you know more about this type of devops stuff?

CodyCBakerPhD commented 1 year ago

Yes, I've been keeping my eye on it and will make some comments later as I notice a couple things while adding similar stuff to https://github.com/catalystneuro/neuroconv/pull/383

luiztauffer commented 1 year ago

@CodyCBakerPhD any specific things you see that should be blocking this merge? I wanted to get the dockerized mode updated and start releasing the images alongside the pypi releases, it will make it very easy to run Panel remotely always with the latest updates