Closed luiztauffer closed 1 year ago
Merging #301 (34a55b3) into master (7bfb2f4) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #301 +/- ##
=======================================
Coverage 66.22% 66.22%
=======================================
Files 35 35
Lines 3458 3458
=======================================
Hits 2290 2290
Misses 1168 1168
Flag | Coverage Δ | |
---|---|---|
unittests | 66.22% <100.00%> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
nwbwidgets/panel.py | 77.56% <ø> (ø) |
|
nwbwidgets/utils/dandi.py | 95.00% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
@rly @bendichter does it look better now?
Yes, much better. Thank you!
@rly cool, can you approve, so I can merge it?
@luiztauffer I like that you are sorting them, but I don't know about how you are changing the asset paths. It may be a bit more readable, but we are losing the identity with the asset path. If we aren't going to keep the asset path, then we might as well render this better. With your proposal, the subject ID is rendered twice for each asset. I would prefer to remove the subject part entirely and just leave it with the filename
@bendichter how about now?
Thanks for the fix!
fix #298