NeurodataWithoutBorders / nwbwidgets

Explore the hierarchical structure of NWB 2.0 files and visualize data with Jupyter widgets.
https://nwb-widgets.readthedocs.io/en/latest/
Other
47 stars 22 forks source link

[Bug]: `make_trial_event_controller` criteria for time columns allows `"_time"` to appear anywhere in column name #314

Open felixp8 opened 11 months ago

felixp8 commented 11 months ago

What happened?

The logic in make_trial_event_controller to determine trial event columns checks for "_time" in column_name, which is weaker than column_name.endswith("_time"), the check used by nwbinspector for example. Unsure what the consensus standard is here but in my case a boolean column called "has_timeout" was included as an alignment field, so I think the stronger check would be better.

Steps to Reproduce

n/a

Traceback

n/a

Operating System

Linux

Python Version

3.10

Package Versions

nwbinspector==0.11.3

Code of Conduct