NeurodataWithoutBorders / pynwb

A Python API for working with Neurodata stored in the NWB Format
https://pynwb.readthedocs.io
Other
178 stars 84 forks source link

update ruff linter settings #1950

Closed stephprince closed 3 months ago

stephprince commented 3 months ago

Motivation

The top-level linter settings in ruff were deprecated and the pyproject.toml file needed to be updated.

I don't think this needs a CHANGELOG.md update.

Checklist

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.77%. Comparing base (12598ea) to head (9eda86d). Report is 20 commits behind head on dev.

:exclamation: There is a different number of reports uploaded between BASE (12598ea) and HEAD (9eda86d). Click for more details.

HEAD has 4 uploads less than BASE | Flag | BASE (12598ea) | HEAD (9eda86d) | |------|------|------| |integration|4|0|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #1950 +/- ## ========================================== - Coverage 92.20% 83.77% -8.44% ========================================== Files 27 27 Lines 2656 2656 Branches 693 693 ========================================== - Hits 2449 2225 -224 - Misses 134 336 +202 - Partials 73 95 +22 ``` | [Flag](https://app.codecov.io/gh/NeurodataWithoutBorders/pynwb/pull/1950/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NeurodataWithoutBorders) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/NeurodataWithoutBorders/pynwb/pull/1950/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NeurodataWithoutBorders) | `?` | | | [unit](https://app.codecov.io/gh/NeurodataWithoutBorders/pynwb/pull/1950/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NeurodataWithoutBorders) | `83.77% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NeurodataWithoutBorders#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

oruebel commented 3 months ago

Oops, I guess we should have merged this PR before #1949. Looks like the changes in #1949 added some ruff issues. Sorry for the trouble.

oruebel commented 3 months ago

Looks like the changes in #1949 added some ruff issues

Just pushed a fix for that error