Open ehennestad opened 4 days ago
From the documentation:
Filter properties should be noted in the ElectricalSeries ‘filtering’ attribute. https://nwb-schema.readthedocs.io/en/latest/format.html#lfp
This seems like a key property that should be highlighted and exemplified in these examples
Oh yeah good point!
Ben Dichter, PhD Data Science Consultant personal website http://bendichter.com/
On Thu, Nov 21, 2024 at 12:47 PM ehennestad @.***> wrote:
From the documentation:
Filter properties should be noted in the ElectricalSeries ‘filtering’ attribute. https://nwb-schema.readthedocs.io/en/latest/format.html#lfp
This seems like a key property that should be highlighted and exemplified in these examples
— Reply to this email directly, view it on GitHub https://github.com/NeurodataWithoutBorders/pynwb/issues/2005#issuecomment-2490905438, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGOEERCMTOI323MCXGG5WD2BXB5NAVCNFSM6AAAAABSGYUUGSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJQHEYDKNBTHA . You are receiving this because you were mentioned.Message ID: @.***>
If the derived data is filtered, but not downsampled, you can store the data in an ElectricalSeries object in a FilteredEphys object instead of a object.
Filtered ephys refers to filtering in general, and does not concern resampling.
I think you're suggesting we remove the "but not downsampled" statement? If so I agree, in my experience at least theta/gamma filtering is often applied to the downsampled LFP data, and filtered ephys should not concern resampling.
I think demonstrating the filtering
attribute is also a good idea!
Just to add:
DecompositionSeries
object: https://github.com/NeurodataWithoutBorders/nwb-schema/blob/473fcc41e871288767cfb37d83315cca7469b9d1/core/nwb.misc.yaml#L103FilteredEphys
type. It is used in only one public dandiset, 000070, and has never featured prominently in tutorials or use cases I have seen. I like @ehennestad 's proposed new text. For FilteredEphys
, if it's not clear in the surrounding text, it should be made clear that that is typically also considered processed data...
I also think demonstrating the filtering
attribute is a good idea.
You can also store multiple filtered time series data in a single DecompositionSeries object
I think the decomposition series is meant for the results of spectral analysis, which is a different operation than filtering
For FilteredEphys, if it's not clear in the surrounding text, it should be made clear that that is typically also considered processed data...
good point!
I think the decomposition series is meant for the results of spectral analysis, which is a different operation than filtering
You are right! My mistake.
What would you like changed or added to the documentation and why?
I am working through the matnwb tutorial and the following seems inaccurate:
About LFP:
About FilteredEphys
Filtered ephys refers to filtering in general, and does not concern resampling. The schema description seems accurate:
https://nwb-schema.readthedocs.io/en/latest/format.html#filteredephys
Suggestions for new text [edited]
LFP: LFP refers to data that has been low-pass filtered, typically below 300 Hz. This data may also be downsampled. Because it is filtered and potentially resampled, it is categorized as processed data.
FilteredEphys: If your data is filtered for frequency ranges other than LFP—such as Gamma or Theta—you should store it in an ElectricalSeries and encapsulate it within a FilteredEphys object.
@bendichter @stephprince @oruebel Please let me know your opinions
Do you have any interest in helping write or edit the documentation?
Yes.
Code of Conduct