coveralls
commented
5 years ago Pull Request Test Coverage Report for Build 133
- 455 of 523 (87.0%) changed or added relevant lines in 6 files are covered.
- 7 unchanged lines in 5 files lost coverage.
- Overall coverage increased (+1.1%) to 60.31%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| kcsd/KCSD.py | 0 | 1 | 0.0% | ||
| kcsd/tests/test_sKCSD.py | 26 | 27 | 96.3% | ||
| kcsd/utility_functions.py | 19 | 20 | 95.0% | ||
| kcsd/sKCSD.py | 74 | 78 | 94.87% | ||
| kcsd/tests/test_sKCSDcell.py | 336 | 350 | 96.0% | ||
| kcsd/validation/plotting_functions.py | 0 | 47 | 0.0% | ||
| <!-- | Total: | 455 | 523 | 87.0% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| kcsd/sKCSD.py | 1 | 83.67% | ||
| kcsd/tests/test_sKCSD.py | 1 | 97.3% | ||
| kcsd/tests/test_sKCSDcell.py | 1 | 96.41% | ||
| kcsd/tests/test_loadData.py | 2 | 98.67% | ||
| kcsd/validation/plotting_functions.py | 2 | 0.0% | ||
| <!-- | Total: | 7 | --> |
| Totals | |
|---|---|
| Change from base Build 130: | 1.1% |
| Covered Lines: | 1673 |
| Relevant Lines: | 2774 |
ccluri
Correct CSD interpolation that works better for complex morphologies. Implemented correct calculation of the contribution to the extracellular potential from a basis source ~bi(s) (eq. 17, doi: 10.7554/eLife.29384) in function forward_model_3D. function forward_model_1D calculates contribution of a specified source in a specified point on the morphology loop (used in potential estimation). The code for calculation of estimation points and distances has been refactored and moved either to sKCSDcell or utility_fuctions and tests added.
Integration using skmonaco has been removed due to inactivity of scikit-monaco.
Code for figures 8, 9, 10 of doi: 10.7554/eLife.29384 has been added.