coveralls
commented
5 years ago Pull Request Test Coverage Report for Build 142
- 7 of 22 (31.82%) changed or added relevant lines in 3 files are covered.
- 7 unchanged lines in 4 files lost coverage.
- Overall coverage increased (+0.5%) to 60.792%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| kcsd/validation/VisibilityMap.py | 0 | 3 | 0.0% | ||
| kcsd/validation/ValidateKCSD.py | 5 | 17 | 29.41% | ||
| <!-- | Total: | 7 | 22 | 31.82% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| kcsd/validation/ValidateKCSD.py | 1 | 30.95% | ||
| kcsd/tests/test_loadData.py | 2 | 98.67% | ||
| kcsd/tests/test_sKCSD.py | 2 | 97.3% | ||
| kcsd/tests/test_sKCSDcell.py | 2 | 96.41% | ||
| <!-- | Total: | 7 | --> |
| Totals | |
|---|---|
| Change from base Build 136: | 0.5% |
| Covered Lines: | 1673 |
| Relevant Lines: | 2752 |
This was a stupid way of testing a feature.
1) Initially I tested numba-jit (https://github.com/Neuroinflab/kCSD-python/issues/57) and saved pickle tables (https://github.com/Neuroinflab/kCSD-python/issues/64) both in the saved_tables branch.
2) To this, Marta and I added the figures and tutorials as I used the features from 1 to improve speed in computations.
Now this presub branch only has the features from 2 (the numba, and pickled tables are reverted in https://github.com/Neuroinflab/kCSD-python/pull/68/commits/9edbca70c6f09b492f48578475ee4a5e274d043a and https://github.com/Neuroinflab/kCSD-python/pull/68/commits/3bd60c932ad199f631bf27cad99020c194de86f6) that I wish to push to the master branch as the numba-jit and pickles are two different enhancements that need to be tested exhaustively before merger to master.