KCSD and lcurve figures fix

Neuroinflab / kCSD-python

Kernel Current Source Density

https://kcsd-python.readthedocs.io/en/latest/

Other

15 stars 23 forks source link

KCSD and lcurve figures fix #71

Closed wsredniawa closed 5 years ago

wsredniawa commented 5 years ago

"Still there are issues with line 280 and 281" - should be fixed now "scale on x and y axis on the subplot C" - I changed to log scale because now I get m_norm and m_resi from kcsd as original values not their logarithms (that is why they were negative).

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 153

0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 60.18%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
kcsd/KCSD.py	0	3	0.0%
<!--	Total:	0	3	0.0%	-->

Totals
Change from base Build 152:	0.0%
Covered Lines:	1676
Relevant Lines:	2785

💛 - Coveralls

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 153

0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 60.18%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
kcsd/KCSD.py	0	3	0.0%
<!--	Total:	0	3	0.0%	-->

Totals
Change from base Build 152:	0.0%
Covered Lines:	1676
Relevant Lines:	2785

💛 - Coveralls

ccluri commented 5 years ago

@wsredniawa This PR and merge do not work. The script fails with

  File "kCSD1D_test_fig1_and_fig2.py", line 278, in <module>
    lpos, name, noise=noise_lvl, srcs=src)
  File "kCSD1D_test_fig1_and_fig2.py", line 247, in main_loop
    m_norm = k.errs[0]
AttributeError: 'KCSD1D' object has no attribute 'errs'

Please continue work on this on https://github.com/Neuroinflab/kCSD-python/tree/lcurve_figures - Please do not merge this branch into master @asiaszmek - I will ask for a review from you when you can.