search

Neuroinflab / kCSD-python

Kernel Current Source Density
https://kcsd-python.readthedocs.io/en/latest/
Other
15 stars 23 forks source link

`builtsin` import renders package unsuitable for Python 2 #77

Closed abukaj closed 5 years ago

abukaj commented 5 years ago

I think the following imports are unnecessary: https://github.com/Neuroinflab/kCSD-python/blob/a7e9447cabe1e36d91f09131ea267f7ccdd92961/kcsd/validation/ValidateKCSD.py#L12 https://github.com/Neuroinflab/kCSD-python/blob/a7e9447cabe1e36d91f09131ea267f7ccdd92961/kcsd/validation/VisibilityMap.py#L8 https://github.com/Neuroinflab/kCSD-python/blob/a7e9447cabe1e36d91f09131ea267f7ccdd92961/kcsd/validation/VisibilityMap.py#L9

According to https://docs.python.org/3/library/builtins.html, the builtins module:

can be useful in modules that provide objects with the same name as a built-in value, but in which the built-in of that name is also needed

which seems not to be the case.