issue #74 file location problem

Neuroinflab / kCSD-python

Kernel Current Source Density

https://kcsd-python.readthedocs.io/en/latest/

Other

15 stars 23 forks source link

issue #74 file location problem #83

Closed wsredniawa closed 5 years ago

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 188

64 of 65 (98.46%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.9%) to 61.315%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
kcsd/KCSD.py	26	27	96.3%
<!--	Total:	64	65	98.46%	-->

Totals
Change from base Build 166:	0.9%
Covered Lines:	1753
Relevant Lines:	2859

💛 - Coveralls

ccluri commented 5 years ago

@abukaj can you please review this?

abukaj commented 5 years ago

May it wait till 24th of Feb? How urgent is this?

On 2/11/19 3:53 PM, Chaitanya Chintaluri wrote:

@abukaj https://github.com/abukaj can you please review this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Neuroinflab/kCSD-python/pull/83#issuecomment-462355764, or mute the thread https://github.com/notifications/unsubscribe-auth/AKx9p-e7EVx1Wvw7BI22HGTo4-AzCgNFks5vMYPdgaJpZM4aWQyD.

ccluri commented 5 years ago

@abukaj Not urgent. Can wait.

abukaj commented 5 years ago

There is at least one failing import: https://travis-ci.org/Neuroinflab/kCSD-python/jobs/491655704 @wsredniawa may you take a look at this?

asiaszmek commented 5 years ago

I think I am OK with Władek's changes.

ccluri commented 5 years ago

@wsredniawa Lets have a teleconference (google hangouts - user name ccluri) about this PR. I am quite confused as to how this is used. Anyone else interested @asiaszmek @abukaj @danek8317 to participate?

GMT Timezone (< 1Hr of your choosing) Friday (8th March) - 0900 to 1200 Tuesday (12th March) - 0900 to 1700 Wednesday (13th March) - 1200 to 1700 Thursday (14th March) - 0900 to 1700

abukaj commented 5 years ago

@ccluri

Friday (8th March) - 0900 to 1200

Very likely I will not manage to; have to check the other dates.

abukaj commented 5 years ago

@ccluri

Friday (8th March) - 0900 to 1200 Very likely I will not manage to; have to check the other dates.

Oh, it is UTC - then for sure I am in the lab after 1100.

abukaj commented 5 years ago

@ccluri Tuesday (12th March) - after 1000 (if there are no issues detected with beta tests of Boar 2.0) Wednesday and Thursday (13th March) - works for me