search

Neuroinflab / kCSD-python

Kernel Current Source Density
https://kcsd-python.readthedocs.io/en/latest/
Other
15 stars 23 forks source link

Figures #90

Closed wsredniawa closed 5 years ago

wsredniawa commented 5 years ago

Script to generate figures for L-curve part

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 195

Changes Missing Coverage Covered Lines Changed/Added Lines %
kcsd/KCSD.py 26 27 96.3%
<!-- Total: 64 65 98.46% -->
Totals Coverage Status
Change from base Build 193: 0.9%
Covered Lines: 1753
Relevant Lines: 2860
💛 - Coveralls
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 195

Changes Missing Coverage Covered Lines Changed/Added Lines %
kcsd/KCSD.py 26 27 96.3%
<!-- Total: 64 65 98.46% -->
Totals Coverage Status
Change from base Build 193: 0.9%
Covered Lines: 1753
Relevant Lines: 2860
💛 - Coveralls
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 205

Changes Missing Coverage Covered Lines Changed/Added Lines %
kcsd/KCSD.py 25 27 92.59%
<!-- Total: 63 65 96.92% -->
Files with Coverage Reduction New Missed Lines %
kcsd/KCSD.py 22 77.34%
<!-- Total: 22 -->
Totals Coverage Status
Change from base Build 193: 0.8%
Covered Lines: 1751
Relevant Lines: 2858
💛 - Coveralls
ccluri commented 5 years ago

Nice! Thanks for addressing my issues. Minor fixes up ahead.

In https://github.com/Neuroinflab/kCSD-python/blob/ea38ff3d9688a1967ca6b0ab164449ebd47d7c08/figures/kCSD_properties/kCSD1D_test_fig1_and_fig2_v2.py#L331

    try:
        os.chdir(saveDir)
    except FileNotFoundError:
        os.mkdir(saveDir)
        os.chdir(saveDir)

stats In this figure, fix the following 1) Alignment of the y-axis label 2) The subplot A need not have the legend 3) Increase spacing between the x-axis and the x-label ('Relative noise level') - please verify that this is consistent with Marta's figures 4) Consistent labels with the others figures, 'kCSD Cross-Validation' and 'kCSD L-Curve' - emphasis on the capitalization 5) Is there any sub-plot title you can think of for A and B?

lc_noise25 0 1) I understand that this is tight space, but see if you can improve the legend placement so that it doesnt overflow, also increase the spacing between the legend and the x-labels 2) Subplot A, what are the black dots? 'Electrodes' - please add a label 3) Units must be written consistently, currently [mV], [mA/mm], please change to (mv) (italicized with $$ in matplotlib math text with round brackets instead) 4) Increase distance between X-labels and X-axis spine ('Distance', 'Norm of prediction error' etc) 5) Labels should be consistent with other figures, True CSD instead of true csd 6) Avoid abbreviations if you can, for instance, 'measured potentials', 'recon. potentials', can be 'measured' and 'reconstructed'; Instead think of a subplot title, 'Potentials' for A etc. Similarly for C, recon. csd with reg. can perhaps be kCSD + regression, and dont mention anything when not regressing? (some ideas here only, please improve this as you like) 7) Missing legends for B and D

ccluri commented 5 years ago

@wsredniawa please update these figures in the manuscript. Pass them to Daniel or Marta. DPI resolution must be consistent.