Closed wsredniawa closed 5 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
kcsd/KCSD.py | 26 | 27 | 96.3% | ||
<!-- | Total: | 64 | 65 | 98.46% | --> |
Totals | |
---|---|
Change from base Build 193: | 0.9% |
Covered Lines: | 1753 |
Relevant Lines: | 2860 |
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
kcsd/KCSD.py | 26 | 27 | 96.3% | ||
<!-- | Total: | 64 | 65 | 98.46% | --> |
Totals | |
---|---|
Change from base Build 193: | 0.9% |
Covered Lines: | 1753 |
Relevant Lines: | 2860 |
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
kcsd/KCSD.py | 25 | 27 | 92.59% | ||
<!-- | Total: | 63 | 65 | 96.92% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
kcsd/KCSD.py | 22 | 77.34% | ||
<!-- | Total: | 22 | --> |
Totals | |
---|---|
Change from base Build 193: | 0.8% |
Covered Lines: | 1751 |
Relevant Lines: | 2858 |
Nice! Thanks for addressing my issues. Minor fixes up ahead.
try:
os.chdir(saveDir)
except FileNotFoundError:
os.mkdir(saveDir)
os.chdir(saveDir)
In this figure, fix the following
1) Alignment of the y-axis label
2) The subplot A need not have the legend
3) Increase spacing between the x-axis and the x-label ('Relative noise level') - please verify that this is consistent with Marta's figures
4) Consistent labels with the others figures, 'kCSD Cross-Validation' and 'kCSD L-Curve' - emphasis on the capitalization
5) Is there any sub-plot title you can think of for A and B?
1) I understand that this is tight space, but see if you can improve the legend placement so that it doesnt overflow, also increase the spacing between the legend and the x-labels
2) Subplot A, what are the black dots? 'Electrodes' - please add a label
3) Units must be written consistently, currently [mV], [mA/mm], please change to (mv) (italicized with $$ in matplotlib math text with round brackets instead)
4) Increase distance between X-labels and X-axis spine ('Distance', 'Norm of prediction error' etc)
5) Labels should be consistent with other figures, True CSD instead of true csd
6) Avoid abbreviations if you can, for instance, 'measured potentials', 'recon. potentials', can be 'measured' and 'reconstructed'; Instead think of a subplot title, 'Potentials' for A etc. Similarly for C, recon. csd with reg. can perhaps be kCSD + regression, and dont mention anything when not regressing? (some ideas here only, please improve this as you like)
7) Missing legends for B and D
@wsredniawa please update these figures in the manuscript. Pass them to Daniel or Marta. DPI resolution must be consistent.
Script to generate figures for L-curve part