Fixed #95 and #93 - Githubissues

Neuroinflab / kCSD-python

Kernel Current Source Density

https://kcsd-python.readthedocs.io/en/latest/

Other

15 stars 23 forks source link

Fixed #95 and #93 #96

Closed abukaj closed 5 years ago

abukaj commented 5 years ago

The KCSD.values() method is 4-8 times faster.

What is more important, it is more numerically stable. Compare the following error maps (no cross validation) with those in #95.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 202

2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 60.408%

Totals
Change from base Build 193:	-0.03%
Covered Lines:	1689
Relevant Lines:	2796

💛 - Coveralls

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 202

2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 60.408%

Totals
Change from base Build 193:	-0.03%
Covered Lines:	1689
Relevant Lines:	2796

💛 - Coveralls

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 202

2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 60.408%

Totals
Change from base Build 193:	-0.03%
Covered Lines:	1689
Relevant Lines:	2796

💛 - Coveralls

ccluri commented 5 years ago

Awesome with the kcsd.values()! Thanks Kuba!