search

Neuroinflab / kCSD-python

Kernel Current Source Density
https://kcsd-python.readthedocs.io/en/latest/
Other
15 stars 23 forks source link

utility_functions import kcsd #97

Closed mczerwinski closed 5 years ago

mczerwinski commented 5 years ago

utility_functions.py imports kcsd kcsd imports utility_functions

This creates an error when importing uninstalled code, and is a bad practice as far as I am aware.

abukaj commented 5 years ago

Move https://github.com/Neuroinflab/kCSD-python/blob/204678556e1878dc52c1e14a0b5662fc05852417/kcsd/utility_functions.py#L42 to the body of kcsd.utility_functions.load_sim()? (just thinking)

abukaj commented 5 years ago

The issue of circular imports is even deeper: kcsd.sKCSD1 imports from kcsd.KCSD which imports kcsd.utility_functions which imports kcsd which imports from kcsd.sKCSD1.

abukaj commented 5 years ago

@asiaszmek, @ccluri is extraction of a new module (kcsd.sKCSD_utils) feasible?

asiaszmek commented 5 years ago

Yes, I think so. I'll looking at it tomorrow.

On Wed, May 08, 2019 at 10:45:05AM -0700, abukaj wrote:

@asiaszmek, @ccluri is extraction of a new module (kcsd.sKCSD_utils) feasible?

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/Neuroinflab/kCSD-python/issues/97#issuecomment-490582986

ccluri commented 5 years ago

I reckon this issue now stands resolved?