Neuroinflab / kCSD-python

Kernel Current Source Density
https://kcsd-python.readthedocs.io/en/latest/
Other
15 stars 23 forks source link

Suspicious use of `super()` #98

Closed abukaj closed 5 years ago

abukaj commented 5 years ago

I think https://github.com/Neuroinflab/kCSD-python/blob/204678556e1878dc52c1e14a0b5662fc05852417/kcsd/sKCSD.py#L614 should be:

    super(sKCSD, self).__init__(ele_pos, pots, **kwargs)

Right now it is skipping call to KCSD1D.__init__() which I doubt to be the intended behaviour. Although it is mostly harmless due to the current implementation of KCSD1D class, it may result in surprising errors in case the implementation changes.