search

NeuromatchAcademy / course-content-dl

NMA deep learning course
https://deeplearning.neuromatch.io/
Creative Commons Attribution 4.0 International
731 stars 265 forks source link

fix: minor broken code due to package versions #953

Open hanieh11 opened 1 week ago

hanieh11 commented 1 week ago

librosa's newest version has changed some function names and variable calling, this branch fixes broken code regarding this issue.

hanieh11 commented 1 week ago

hi, actually only 2 lines of the code have been changed. in the first version I ran every cell of the notebook and since the output was included in both notebooks too much of the source code was considered to be changed. Two lines are: librosa.display.waveshow(y=y, sr=sample_rate); S = librosa.feature.melspectrogram(y=y, sr=sr)

iamzoltan commented 1 week ago

Yes, I understand. This is due to your environment. It is best to run jupyter notebook locally. Change the lines, and clear all cell and kernel before saving. Try that.

hanieh11 commented 1 week ago

Yes, I understand. This is due to your environment. It is best to run jupyter notebook locally. Change the lines, and clear all cell and kernel before saving. Try that.

In my second commit i only changed the lines without running it, therefore the notebook output must be the same as source code. But since you mentioned clearing all the outputs, in the 3rd commit the changes were made and all the outputs were cleared.