Issue on page /tutorials/W3D3_OptimalControl/instructor/W3D3_Tutorial1.html

NeuromatchAcademy / instructor-course-content

This repo is used to create the instructor jupyter-book

MIT License

2 stars 0 forks source link

Issue on page /tutorials/W3D3_OptimalControl/instructor/W3D3_Tutorial1.html #16

Open Alxec opened 11 months ago

Alxec commented 11 months ago

In Tutorial 1 on W3D3 (Optimal Control) there is an issue with the code for Interactive Demo 4.

It sets the params as params = [stay_prob, high_rew_p, low_rew_p, threshold] while the function "binaryHMM_belief" unpacks those params in different order: p_stay, low_rew_p, high_rew_p, threshold = self.params

The code should be as this: params = [stay_prob, low_rew_p, high_rew_p, threshold]

iamzoltan commented 1 month ago

was this addressed?

Alxec commented 4 weeks ago

was this addressed?

Doesn't look like it