Quote posts

[sneakers-the-rat]

This is a ripoff of treehouse's quote posts.

upstream masto is going too slow in implementing quote posts and i want them. we can vote on merging this if we'd like to but i just want to get the patch working and prepared anyway.

So far what i've done is just cherrypick the commits from the two pull requests and any that have "quote" in the commit message....

• https://gitea.treehouse.systems/treehouse/mastodon/pulls/36
• https://gitea.treehouse.systems/treehouse/mastodon/pulls/37
• https://gitea.treehouse.systems/treehouse/mastodon/commit/1a7cf766619eec917991b34f747cb0ddccc44ab1
• https://gitea.treehouse.systems/treehouse/mastodon/commit/46d70b1ca6cea86806fcfa47e3c143972e315ad8
• https://gitea.treehouse.systems/treehouse/mastodon/commit/98ae4ef813b9cc6750032cad2eca4a017ad492fa
• https://gitea.treehouse.systems/treehouse/mastodon/commit/8fd45df06ea061b99f5a6f8c69b8ff1c9971a32b
• https://gitea.treehouse.systems/treehouse/mastodon/commit/f7ac4c332b22edb9164ac98fdf187a0bcfbf41df

So far that's a woefully inadequate job, so what i think this gets us is places to look for changes.

TODO

UI

• [ ] don't crash when clicking quote while logged out https://types.pl/@jj/112862164894124697
• [x] visually offset quote more
• [x] make the whole quote area clickable - whole text area is clickable but it doesn't seem like it atm
• [x] the links don't work - for some reason there is a link to the profile page in the name and a link to the post in the body, but neither of them are clickable. this is probably bc the react component is intercepting the clicks and the click handler isn't working.
• [x] styling - add avatar and handle to the title bar
• [ ] when drafting a quote post, the quote isn't displayed in the compose view, so it's not clear that you're quoting something. when you compose a reply, that is there with an 'x' box to allow you to cancel doing a reply, and I think that's supposed to be here but it's broken.
• [ ] quotes are not displayed from the quoted post - ideally one would be able to see when they are quoted, but that doesn't seem to be shown now. should be a way to pop into a feed that shows the quotes of a post.
• [ ] i think the truncation is good, but also glitch has that normally, so i'm not sure why we wouldn't just embed the quote as another Status component within the status component? probably some redux nightmare reason
• [ ] quoted posts go below the quote post

Federation

• [x] Make them federate as a boost as well as a post, the OP should be notified and the quoted post should be federated to the other instances
  • rather than federating as a boost, just notify the person, it looks like a normal post to them https://github.com/NeuromatchAcademy/mastodon/commit/d8fcac65b3d58bcd8e3c1380359747bc9dcd2e

Importing from treehouse

make sure we got a complete import of prior work so we don't have a messy ass merge when we try and contrib back to them:

• [ ] go through and take a look at all the other places that have changed in the treehouse code that weren't necessarily labeled as changes to quote posts and make sure this version matches theirs.
• [ ] do a code search for 'quote' and make sure there aren't any new places that we don't have in this patch and import those.

i can already see a number of changes in other commits where quote stuff was changed along with other stuff, which is fine, they make no promises about feature portability or anything. anyway opening this up as a draft

[sneakers-the-rat]

ok it working, but there are some bugs to fix and improvements to make. here is an example:

• visually offset quote more: that whole text area is clickable but it doesn't seem like it atm, we should add a border and a bit more padding.
• the links don't work - for some reason there is a link to the profile page in the name and a link to the post in the body, but neither of them are clickable. this is probably bc the react component is intercepting the clicks and the click handler isn't working.
• styling - add avatar and handle to the title bar
• when drafting a quote post, the quote isn't displayed in the compose view, so it's not clear that you're quoting something. when you compose a reply, that is there with an 'x' box to allow you to cancel doing a reply, and I think that's supposed to be here but it's broken.
• quotes are not displayed from the quoted post - ideally one would be able to see when they are quoted, but that doesn't seem to be shown now. should be a way to pop into a feed that shows the quotes of a post.
• i think the truncation is good, but also glitch has that normally, so i'm not sure why we wouldn't just embed the quote as another Status component within the status component? probably some redux nightmare reason

edit: moved these up to the OP

[github-actions[bot]]

This pull request has merge conflicts that must be resolved before it can be merged.

[sneakers-the-rat]

I think for the sake of this PR i'm gonna punt on a lot of the style problems and just try and get functional problems to work and then iterate in future PRs by putting the TODOs on the wiki before i merge

[sneakers-the-rat]

mentioning is just about that easy: https://github.com/NeuromatchAcademy/mastodon/pull/52/commits/d8fcac65b3d58bcd8e3c1380359747bc9dcd2e

3c