Fix optional imports for OSGi

NeuronRobotics / nrjavaserial

A Java Serial Port system. This is a fork of the RXTX project that uses in jar loading of the native code.

Other

345 stars 143 forks source link

Fix optional imports for OSGi #109

Closed crea-doo closed 6 years ago

crea-doo commented 6 years ago

Follow-up PR related to https://github.com/NeuronRobotics/nrjavaserial/pull/100. Now the JNA dependency is really optional: On Windows there is a check if the classes are present and if not available ports are detected using the old behaviour.

The RFC2217 functionality is unchanged and only needs the dependency present when a TelnetSerialPort ist instanciated (on all platforms).

crea-doo commented 6 years ago

The Travis buils is failing because the travis configuration is somehow broken:

Travis doesn't support oraclejdk7 any more
openjdk7 isn't able to start up the Gradle wrapper

I'll provide a fix...

crea-doo commented 6 years ago

Should be fixed in #110...

msteigenberger commented 6 years ago

+1 I'd need that change for my openhab binding. Thanks!

martinvw commented 6 years ago

Hello what is the status here, is there anyone we can / should mention to increase the chances of it being merged?

kaikreuzer commented 6 years ago

@madhephaestus, We (meaning @eclipse SmartHome and @openhab projects) are heavily dependent on this fix - any chance to have it merged and do a new official release any time soon? 0.13.0 is already more than a year old, so it would be awesome if you could spend a little time to move this forward - thanks!

madhephaestus commented 6 years ago

now in 3.14.0, should be synced to Maven Central in a day or so

martinvw commented 6 years ago

@madhephaestus Thanks!

kaikreuzer commented 6 years ago

Excellent, many thanks!

madhephaestus commented 6 years ago

repositories { //com.neuronrobotics hosting point maven { url 'https://oss.sonatype.org/content/repositories/staging/' } } dependencies { compile "com.neuronrobotics:nrjavaserial:3.14.0" }

for the impatient