search

NeuronRobotics / nrjavaserial

A Java Serial Port system. This is a fork of the RXTX project that uses in jar loading of the native code.
Other
345 stars 143 forks source link

commons-net in maven dependencies #142

Closed t5keeper closed 4 years ago

t5keeper commented 5 years ago

Maven artifact

    <dependency>
      <groupId>com.neuronrobotics</groupId>
      <artifactId>nrjavaserial</artifactId>
      <version>3.15.0</version>
    </dependency>

Has dependency with scope compile.

    <dependency>
      <groupId>commons-net</groupId>
      <artifactId>commons-net</artifactId>
      <version>3.3</version>
      <scope>compile</scope>
    </dependency>

Which actually not used. Please remove it.

wborn commented 5 years ago

Looks like some of the rfc2217 classes depend on it, e.g.:

https://github.com/NeuronRobotics/nrjavaserial/blob/e06ed10e23284c36d19225b907e0b7a3b2736833/src/main/java/gnu/io/rfc2217/TelnetSerialPort.java#L69-L74