NeuronRobotics / nrjavaserial

A Java Serial Port system. This is a fork of the RXTX project that uses in jar loading of the native code.
Other
344 stars 142 forks source link

Added FreeBSD aarch64 (ARM64) support #218

Closed siepkes closed 3 years ago

siepkes commented 3 years ago

Tested on a Raspberry Pi 4.

siepkes commented 3 years ago

Thanks for the prompt review! I've addressed your feedback. On closer inspection I also noticed I needed to add the variant in the makefile so the resulting binary has the correct name.

You might already know about it but there is also the Maven NAR plugin to aid in dealing with native code.

siepkes commented 3 years ago

Alright, took some tries but I think we've got there! Thanks for your patience!

Building with the -m64 compiler flag removed yields exactly the same binary (I compared the hashes).