Closed crea-doo closed 7 years ago
Found out that this issue also duplicates #44...
Indeed, I had this wish much earlier ;-) FTR: In openHAB, we are maintaining this fork, which had been prepared by @cvanorman - I would hope to switch back to the official build again one day, but there doesn't seem much activity here anymore, which doesn't make me too confident...
Product is quite stable, so why should there be changes?
@kaikreuzer did you make any changes in the code, that would be worth having here?
Hey! This looks great, and I apologise for being out of the loop this past year. I will have time this summer, maybe we can work together to unify the changes and get a new release out?
Product is quite stable, so why should there be changes?
Then you do not use it enough :-) We were blocked by (non exhaustive list): https://github.com/NeuronRobotics/nrjavaserial/issues/23, https://github.com/NeuronRobotics/nrjavaserial/issues/28, https://github.com/NeuronRobotics/nrjavaserial/issues/44, https://github.com/NeuronRobotics/nrjavaserial/issues/60, https://github.com/NeuronRobotics/nrjavaserial/issues/72, https://github.com/NeuronRobotics/nrjavaserial/issues/73, https://github.com/NeuronRobotics/nrjavaserial/issues/95, https://github.com/NeuronRobotics/nrjavaserial/issues/96
I will have time this summer, maybe we can work together to unify the changes and get a new release out?
@madhephaestus Sounds great, it would be awesome to revive this project again together. I would mainly like to invite @cvanorman as he prepared all the changes in the openHAB fork and should be able to provide PRs against the official repo as well.
I also have to say that I appreciate the work done so far but there are also several issues that should be solved e.g. https://github.com/NeuronRobotics/nrjavaserial/pull/97 ;-)
@madhephaestus: A new release soon sounds good to me - also would contribute to it :-)
@crea-doo @kaikreuzer @andyrozman I pulled together the outstanding PR's and made a release of 3.13.0 I have also created a development branch for receiving PR's in the future, as id like to have this look a bit more like gitflow. Hows this sound for a starting point?
Thanks @madhephaestus, definitely a good starting point!
A few comments about the 3.13.0 release:
com.sun.jna.platform.win32
and org.apache.commons.net.telnet
- I think both would have to be optional only.I try to solve number 2 and provide a PR soon...
It's not necessary to ship dependencies with the lib.
Changes taken from https://github.com/cvanorman/nrjavaserial/issues/1 and https://github.com/msteigenberger/nrjavaserial/commit/b9b36cbb4d83635261715188ccb945ac0ffdec72