Neurotech-HQ / heyoo

Opensource python wrapper to WhatsApp Cloud API
https://pypi.org/project/heyoo/
MIT License
442 stars 97 forks source link

Only useable with Python 3.10 #39

Closed soerenetler closed 1 year ago

soerenetler commented 1 year ago

With commit 41f7297 @nikbott added return types for getter methods this takes advantage of the newly introduces PEP 604: New Type Union Operator (https://docs.python.org/3/whatsnew/3.10.html#pep-604-new-type-union-operator). This limits the library now to python 3.10 only. I think the projekt should support also older versions. This could be done using typing union (https://docs.python.org/3/library/typing.html#typing.Union).

Kalebu commented 1 year ago

Hi @soerenetler, Thanks for pointing that out

I agree with you, older version should be supported, can you work on a pull request to fix this?

filipporomani commented 1 year ago

I just opened a pull for this. https://github.com/Neurotech-HQ/heyoo/pull/53

I removed return type, I don't know if it's worth it or not.

filipporomani commented 1 year ago

@Kalebu this can be marked as closed now i suppose.

Kalebu commented 1 year ago

Sure , Closing it