Neurrone / beets-audible

Organize Your Audiobook Collection With Beets
MIT License
111 stars 19 forks source link

Missing series fields #3

Closed SenorSmartyPants closed 2 years ago

SenorSmartyPants commented 2 years ago

Some series fields are missing in my testing.

Missing from MP3

Missing from M4B

The only series field present in M4B is grouping

https://www.audible.com/pd/Leviathan-Wakes-Audiobook/B073H9PF2D

image

Neurrone commented 2 years ago

Thanks for the bug report. Let me investigate, I remember seeing some of these fields do get added to the mp3s I've tested, so I'm not sure what's going on there.

Neurrone commented 2 years ago

For MP3, MVIN is already set. If by show work you mean shwm, that should only be applicable for m4b files.

For M4b, I've just pushed an update that adds mvn (series name) and soal (album sort). I'm not able to add the series position under mvi as not all values can be converted to integers per the tag requirements (e.g, "1-3" for a multi-book m4b) which causes a runtime error if attempting to write such invalid data.

I'll add shwm for M4b the next time I work on this.

@seanap how does Mp3tag add series position to m4b files? Does it use custom tags?

SenorSmartyPants commented 2 years ago

You could test that mvi is an integer and then add the field. I would imagine more will be integers than not.

seanap commented 2 years ago

@Neurrone My mp3tag script puts the series position in both the mvin built in tag and series-part which is a custom tag. The movement (mvin) and movementname (mvnm) are built into id3v2.3+. I had also added two custom tags (series and series-part) just incase something ever looked at them. I don't think anything looks for the series in movement or custom series tags. Prologue was trying to use TIT1 Content Group, but that is a singular tag and doesn't have a separate series position component.

Form the mp3tag tag filed mappings page: image

SenorSmartyPants commented 2 years ago

I had also added two custom tags (series and series-part) just incase something ever looked at them.

Audiobookserver is looking at these fields now.

https://www.audiobookshelf.org/docs/#metadata

Here's the code they use to check all tags https://github.com/advplyr/audiobookshelf/blob/f15be4c96eec8a5bdd9420f75f1c7bf8d11fab57/server/utils/prober.js#L169-L200

Neurrone commented 2 years ago

I've added the following tags to m4b files:

This should fix all the missing tags for m4b files.

Neurrone commented 2 years ago

I've also updated mp3 files to use txx_series-part instead of seriesposition to match audiobookshelf.

This should be all the missing tags. Let me know if I've missed out anything.

SenorSmartyPants commented 2 years ago

Series and Series-part are missing from M4Bs.

But everything else seems there.

Neurrone commented 2 years ago

Ah, I wasn't sure how to add those tags to m4b files, I'll reopen this.

Neurrone commented 2 years ago

The missing Series and Series-part tags were added in #18.