search

Neutone / neutone_sdk

Join the community on Discord for more discussions around Neutone! https://discord.gg/VHSMzb8Wqp
GNU Lesser General Public License v2.1
465 stars 21 forks source link

[cm] Separating delay into buffering and modeling #39

Closed christhetree closed 1 year ago

christhetree commented 1 year ago

This PR separates and renames the delay reporting methods into model delay and buffering delay since they need to be handled differently by the C++ plugin. Buffering delay is only introduced by the SQW and is purely a function of sampling rate and buffer size. Model delay can be anything and is highly dependent on the model implementation.

Since this is a breaking change that is not reverse compatible, I've updated the version to 1.3.0

This PR is the Python companion PR to the C++ changes in the plugin https://github.com/QosmoInc/neutone-plugin/pull/52

bogdanteleaga commented 1 year ago

LGTM, just one tiny comment. Perhaps it would be good to have some tests for the delay wrapper, but that could come with the future changes to render_audio_sample as well.