search

Neutone / neutone_sdk

Join the community on Discord for more discussions around Neutone! https://discord.gg/VHSMzb8Wqp
GNU Lesser General Public License v2.1
465 stars 21 forks source link

[cm] Parameter refactoring #71

Open christhetree opened 7 months ago

christhetree commented 7 months ago

This PR refactors the parameter logic in preparation for the Neutone Gen SDK which will require adding a new Wrapper class and the addition of new types of parameters.

This PR enables inheritance to be used for the parameters even though TorchScript does not support subclassing, by ensuring all parameter logic is contained to the constructors of wrappers.

MAX_N_PARAMS is also separated out so that it can be defined separately for Neutone FX and Neutone Gen (future PR).