search

Neutone / neutone_sdk

Join the community on Discord for more discussions around Neutone! https://discord.gg/VHSMzb8Wqp
GNU Lesser General Public License v2.1
465 stars 21 forks source link

[cm] Categorical parameter implementation #73

Open christhetree opened 7 months ago

christhetree commented 7 months ago

This PR adds a CategoricalNeutoneParameter class. It also refactors the original KnobNeutoneParameter to be called ContinuousNeutoneParameter.

christhetree commented 6 months ago

Two small comments on this one.

Also, more generally, is there a big benefit to fitting both of these under a generic Knob class? I think Categorical could also be implemented as a slider or something similar and don't directly see the benefit of having the Knob superclass.

Yeah I was using the Knob distinction during development of the Gen SDK, but now that the dust has settled it doesn't provide any real benefit so I'll get rid of it.