search

NeutrinosPlatform / cordova-plugin-document-scanner

cordova plugin for document scan
https://www.neutrinos.co/
MIT License
85 stars 60 forks source link

Pass enhanced image to cordova, if user preffered it #57

Closed serpaulius closed 5 years ago

serpaulius commented 5 years ago

Platform: iOS (WeScan library) Bug: enhanced image, which appears after pressing "magic wand" button in Review step, is not passed to Cordova Solution: if user presses the "magic wand" button, pass enhanced image to Cordova.

serpaulius commented 5 years ago

Hey @serpaulius Thanks a lot for the contribution. Just a note : I don't see the js interface for the user to pass in his preference to the plugin

Hey, @ChrisTomAlx,

The thing is, that the WeScan library provides a button "magic wand" during Review step, which (if pressed) changes the picture to B&W - however, the plugin passes the result of the non-B&W image, and I think this is not an expected behavior.

So I made a change - now, if user presses that "magic wand" in WeScan and sees B&W image, the visible, B&W version is being passed to the cordova result, instead of the original image.

Does the change make any sense? Maybe you expect to behave it in some other way?

ChrisTomAlx commented 5 years ago

Tested this.. Works great. I will make a few more changes to support swift ver 4.2 and release this as soon as possible.

Thanks again for your contribution. Much appreciated!