need error handler fix for registered horses with no tamer

Nevakanezah / HorseEnhancer

All-natural horse enhancement for Minecraft 1.12 - 1.14

MIT License

3 stars 2 forks source link

need error handler fix for registered horses with no tamer #40

Closed SofieHL closed 4 years ago

SofieHL commented 4 years ago

Many horses on my server were spawned already tamed and therefore show "null" as the tamer. When any of these horses are registered, the "/he list" command stops working. It will say "An internal error occurred while attempting to perform this command"

Nevakanezah commented 4 years ago

I must've broken something in one of my later commits, I'll give this a look tonight. Thanks for letting me know!

Nevakanezah commented 4 years ago

Looking over it, it seems I'm going to need some more information to track this one down. @SofieHL , would you be able to provide any/all of the following?

Your minecraft version
A copy of your minecraft logs file where the error occurred

In the meanwhile, you might be able to work around the issue by spawning a new horse, taming it, then killing it, as this will trigger my cleanup code to remove invalid horses.

Nevakanezah commented 4 years ago

Upon further review, I was overthinking the issue a bit. I've changed the commands that interact with the horse list so they run a cleanup before processing, which should prevent this from happening any more.

I've also posted a 1.0.1 update that contains this change: https://www.spigotmc.org/resources/horseenhancer-1-0-mc-1-12-1-13-1-14.75692/history