The micro menu is not properly restored in WoW Classic when a vehicle is left. This results in the micro menu disappearing when mounting the vehicle but not reappearing after leaving it.
Root cause
The root cause seems to be that ActionBarController_UpdateAll and UpdateMicroButtonsParent do not trigger RestoreMicroButtonParent after leaving a vehicle. I did not further investigate, but it seems as (C_PetBattles and C_PetBattles.IsInBattle()) in MicroMenuMod:ActionBarController_UpdateAll does not work in WoW classic. Similarly, the if-condition in MicroMenuMod:UpdateMicroButtonsParent does not seem to work either.
Discussion
The changes I made seem to work for Wotlk 3.4.147966. That means, the micro menu is properly hidden when in a vehicle and shown again after having it left. However, I'm not sure if my changes work for retail and since I don't play retail, I would be in need of aid here.
While testing I also had a few cases where, for some reason, the micro bar did show up only for some seconds after leaving a vehicle, but then disappearing again. I hope it was just too much coffee...
Nevcairiel
commented
2 weeks ago
Issue
The micro menu is not properly restored in WoW Classic when a vehicle is left. This results in the micro menu disappearing when mounting the vehicle but not reappearing after leaving it.
Root cause
The root cause seems to be that
ActionBarController_UpdateAllandUpdateMicroButtonsParentdo not triggerRestoreMicroButtonParentafter leaving a vehicle. I did not further investigate, but it seems as(C_PetBattles and C_PetBattles.IsInBattle())inMicroMenuMod:ActionBarController_UpdateAlldoes not work in WoW classic. Similarly, the if-condition inMicroMenuMod:UpdateMicroButtonsParentdoes not seem to work either.Discussion
The changes I made seem to work for Wotlk 3.4.147966. That means, the micro menu is properly hidden when in a vehicle and shown again after having it left. However, I'm not sure if my changes work for retail and since I don't play retail, I would be in need of aid here. While testing I also had a few cases where, for some reason, the micro bar did show up only for some seconds after leaving a vehicle, but then disappearing again. I hope it was just too much coffee...
Fixes #154