Nevcairiel / Bartender4

ActionBar AddOn for World of Warcraft
https://www.wowace.com/projects/bartender4/
61 stars 34 forks source link

Revert "Work-around issues with the PetBar not accepting modified key… #156

Open zahnom opened 1 year ago

zahnom commented 1 year ago

Issue

The keybindings for the pet bar don't work at all when in a vehicle or a drake (e.g. in occulus). When disabling Bartender the issue is gone. So the current problem is that

Root cause

~Looks like the quick fix of e79877f1e2e6b3621876a27fa6f00eed24e9cebe now causes problems in Wotlk 3.4.1.47966. If I revert this commit everything works smooth again.~ Edit: I was a bit overhasty with reverting e79877f1e2e6b3621876a27fa6f00eed24e9cebe. The issue with the modified keybindings on the petbar reappears when reverting. The root cause for the petbar keybindings not working when on vehicle is the work-around of e79877f1e2e6b3621876a27fa6f00eed24e9cebe, though.

Solution

I don't have a definitive solution, but at least something that could improve the situation. I modified PetBarMod:ReassignBindings so that the work-around is only used for bindings with a modifier, and the "traditional" way is used for the others. As a result, the keybindings for pets work for both normal and modified bindings and when on a vehicle at least the normal keybindings work. Keybindings with modifiers still won't work when on a vehicle though. But I think it's worth adding this improvement to at least help all the people with non-modified keybindings on the petbar.