search

Nevcairiel / HereBeDragons

13 stars 5 forks source link

Patch 9.1 introduces maps past ID 2000 #13

Closed zarillion closed 3 years ago

zarillion commented 3 years ago

While working on HandyNotes: Shadowlands I discovered that my calls to HereBeDragons:GetWorldCoordinatesFromZone(x, y, id) were failing for the new Grommit Hollow cave in Korthia, and only for that cave. I tracked it down to this logic:

https://github.com/Nevcairiel/HereBeDragons/blob/master/HereBeDragons-2.0.lua#L237

        -- try to fill in holes in the map list
        for i = 1, 2000 do
            if not mapData[i] then
                local mapInfo = C_Map.GetMapInfo(i)
                if mapInfo and mapInfo.name then
                    processMap(i, mapInfo, nil)
                end
            end
        end

Unforunately Blizzard is now past map ID 2000. The Grommit Hollow cave has an ID of 2007, so API calls are now failing on initial login, then succeed after a /reload. Can you bump that limit up for us and update HandyNotes? ❤️

zarillion commented 3 years ago

Thanks!