search

Nevcairiel / Inventorian

Inventorian is a simple bag addon for World of Warcraft that combines all individual bags into one huge inventory for easier management.
https://www.wowace.com/projects/inventorian
7 stars 3 forks source link

Classic Keyring #8

Closed questionmarkquestionmark closed 4 years ago

questionmarkquestionmark commented 4 years ago

Today wow classic updated to and added the keyring. Current version of classic inventorian doesn't support this, when you click the keyring it just opens the inventory and not a separate keyring window.

kevbry commented 4 years ago

For a quick fix, edit Inventorian.lua and change BAG_CONFIG:bags from: { BACKPACK_CONTAINER, 1, 2, 3, 4 } to { KEYRING_CONTAINER, BACKPACK_CONTAINER, 1, 2, 3, 4 }

No idea if this is going to break something else, but I haven't had any issues so far.

kevbry commented 4 years ago

Pretty sure I have this working, is there anyone around to accept a PR?

Nevcairiel commented 4 years ago

Adding the keyring to the main bag window is not ideal, as it would be rather confusing to have an additional 16 slots there which you can't use for normal items.

I was planning to make a new window and add a key button to the bag frame, which I'll likely work on this weekend.

Twizt3r commented 4 years ago

Any news on this keyring update ?

denisgenon commented 4 years ago

No news ? :(

sk42git commented 4 years ago

Quick and very dirty temporary fix here. Keyring window shows some redundant information (currency and bag slot) but otherwise works. May have issues manually moving keys around, but right-clicking them should still work. Probably throws some new errors - you're on your own there. Can't test with a full keyring to make sure it resizes properly/etc, but I don't expect any problems with that. Added "/inventorian keys" command, just in case.

Links contain an updated Inventorian.lua (remove .txt. extension if you dl from git). Be sure to back up your original before replacing it.

Inventorian.lua.txt https://pastebin.com/LRgNrL4F

blastehh commented 4 years ago

Check out my fork here, it's pretty much fully working https://github.com/blastehh/Inventorian

Nevcairiel commented 4 years ago

This is now available