Crash in CLAVVideo::CompleteConnect()

Nevcairiel / LAVFilters

LAV Filters - Open-Source DirectShow Media Splitter and Decoders

GNU General Public License v2.0

7.36k stars 789 forks source link

Crash in CLAVVideo::CompleteConnect() #445

Closed clsid2 closed 2 years ago

clsid2 commented 2 years ago

Details taken from a MPC-HC crash dump.

lav_crash_checkdirectmode

m_pDecoder is NULL, which causes crash in GetPixelFormat() call in CheckDirectMode().

I am not sure what the correct solution is. Refuse connection due to the HW decoder failure? Or just skip call to CheckDirectMode() in this situation? Or maybe m_pDecoder should never be NULL here and bug is elsewhere?

Nevcairiel commented 2 years ago

m_pDecoder really shouldn't be NULL at this point, indicating that an earlier failure wasn't handled properly. I can still add a check to GetPixelFormat so it doesn't crash, however its not guaranteed that it won't run into the same issue later on somewhere.