Do not guess arbitrary aac stream parameters

Nevcairiel / LAVFilters

LAV Filters - Open-Source DirectShow Media Splitter and Decoders

GNU General Public License v2.0

7.34k stars 789 forks source link

Do not guess arbitrary aac stream parameters #469

Closed kasper93 closed 2 years ago

kasper93 commented 2 years ago

I found this the other day and I don't like it. So there is that :) If it really helps, maybe it should be fixed in ffmpeg? Anyway feel free to reject this PR. I was just cleaning local repo.

Nevcairiel commented 2 years ago

I don't quite remember what kind of file this was, but there were some edge cases where it managed to figure out the codec, but for some reason not the stream information, so it seemed sensible to let the decoder try anyway, instead of just giving up. It really shouldn't harm anything, so i think I'll keep it.