search

Nevcairiel / Mapster

Mapster is a very simple world map enhacement addon for World of Warcraft
https://www.wowace.com/projects/mapster/
18 stars 2 forks source link

Taint when reporting a player AFK in Battlegrounds (Classic) #23

Closed clausjoergensen closed 4 years ago

clausjoergensen commented 4 years ago 
Global variable UIDROPDOWNMENU_MENU_LEVEL tainted by Mapster - Interface\FrameXML\UIDropDownMenu.lua:40
    securecall()
    Interface\FrameXML\UIDropDownMenu.lua:74 UIDropDownMenu_Initialize()
    Interface\AddOns\Blizzard_SharedMapDataProviders\GroupMembersDataProvider.lua:168
    xpcall()
    Interface\AddOns\Blizzard_MapCanvas\Blizzard_MapCanvas.lua:759 WorldMapFrame:ProcessCanvasClickHandlers()
    Interface\AddOns\Blizzard_MapCanvas\MapCanvas_ScrollContainerMixin.lua:127
clausjoergensen commented 4 years ago

Can confirm the taint is caused by the RawHook of WorldMapFrame.ScrollContainer.GetCursorPosition. Implementation doesn't matter, any raw hook of the GetCursorPosition causes a taint when reporting people in BGs.

Root cause might very well be on Blizzards end.

Nevcairiel commented 4 years ago

That hook is unfortunately quite essential for what Mapster does, without that, in classic at least, all that would be possible would be the normal fullscreen map. Any change to its size requires adjusting the cursor size calculations otherwise clicked areas no longer match.

Hence, there isn't really anything I can do.