Nevcairiel / Mapster

Mapster is a very simple world map enhacement addon for World of Warcraft
https://www.wowace.com/projects/mapster/
18 stars 2 forks source link

Enhancement Request: use the Blizzard AddOns Compartment (PR92 is a suggested update to include) #91

Open JPEscher opened 3 months ago

JPEscher commented 3 months ago

As per: https://warcraft.wiki.gg/wiki/Addon_compartment a new feature with DF was the addons compartment for easy access to add on configs without cluttering the minimap would it be possible to use it?

i tried what they show for manual at the link in Interface/AddOns/Mapster/Config.lua and this code seems to work. hope it helps!


local aboutText = "Mapster";
local mouseButtonNote = "\nYour Map, Improved";
AddonCompartmentFrame:RegisterAddon({
    text = aboutText,
    icon = "Interface/AddOns/Mapster",
    notCheckable = true,
    func = function(button, menuInputData, menu)
        Settings.OpenToCategory("Mapster")
    end,
    funcOnEnter = function(button)
        MenuUtil.ShowTooltip(button, function(tooltip)
            tooltip:SetText(aboutText .. mouseButtonNote)
        end)
    end,
    funcOnLeave = function(button)
        MenuUtil.HideTooltip(button)
    end,
})

image image

JPEscher commented 3 months ago

created PR for you to review. hope you like and it helps https://github.com/Nevcairiel/Mapster/pull/92

JPEscher commented 3 months ago

note the ace is out of date... https://github.com/hurricup/WoW-Ace3/tree/master might wanna grab the zip and update AceAddon-3.0 AceConfig-3.0 AceConsole-3.0 AceDB-3.0 AceDBOptions-3.0 AceEvent-3.0 AceGUI-3.0 AceHook-3.0 AceLocale-3.0 CallbackHandler-1.0 LibStub

JPEscher commented 3 months ago

latest official release when i write is https://www.wowace.com/projects/ace3/files/5561981 all are here https://www.wowace.com/projects/ace3/files

JPEscher commented 3 months ago

based on later findings i came back. i might be wrong on ace. there was an interaction issue due to an out of date mod.

JPEscher commented 2 months ago

@Nevcairiel have you reviewed this? would love to know if it is accepted, even if the PR is not how you'd like it implemented.